-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] real_estate: Addon to manage real estate #17
base: 16.0
Are you sure you want to change the base?
Conversation
What I wanted on the first version is to inherit from all properties of res.partner(and even added ones). As an estate has all properties of addresses. This approach has a drawback is the implementation it needs. But IMHO, the advantages have more pro than cons. I'm not too much in favor of these changes |
I understand your point, but one of the problems, which arose when trying to use the currently published version, is that the fields of res.partner many2one list the contacts and also the properties, which forces us to add unnecessary domains so as not to list the properties . |
I agree it should be an isolated one with the needed m2o, or maybe fields sync. |
@rousseldenis So, would it be possible to validate the PR, with the new approach? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all,
for a project I'm working on (16.0) I need the management of estate.
My needs are very basic at the moment so I could create my custom module, but if it possible to use an OCA one I am happier.
For what I can understand from the comments and the code, this version is "better" than the 13.0.
So if it is possible to update the commit to have a runboat to test I will do it.
Thanks
@jelenapoblet is this PR, the other PR it's closed |
Got it @curonny , thank you! Is there anything else we can do to move this forward? |
everything is done, waiting for approval |
@curonny Could you provide migration scripts if needed ? |
real_estate_latitude = fields.Float(digits=(10, 7)) | ||
real_estate_longitude = fields.Float(digits=(10, 7)) | ||
comment = fields.Html() | ||
owner_ids = fields.Many2many( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be enhanced in order to support different kind of property (bare ownership, ....).
country_code = fields.Char( | ||
related="country_id.code", | ||
) | ||
real_estate_latitude = fields.Float(digits=(10, 7)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are in the real estate model, so removing real_estate
should be great for both fields
@curonny Could you rebase ? |
index=True, | ||
) | ||
active = fields.Boolean(default=True) | ||
image = fields.Image( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you use theimage.mixin
present in v16 in order to manage all sizes ?
No description provided.